Matthew Martin wrote: > Since __progname is not exposed in stdlib.h, use getprogname(3) instead. > While here remove the useless cast.
yes. i also removed the declaration a few lines above. > If this is ok, I'd like to also replace the uses of __progname > throughout the tree with getprogname(). Rationale for this is > setprogname takes a const char *, which means __progname should also be > const. Instead of fixing all the declarations throughout the tree, use > getprogname(3) which is the documented API anyway. this is probably more noise than improvement, but if a utility is being reworked or updated for some other reason, it's something to tack on.
