Re: armv7 _dcache_wbinv_all, or _dcache_wb_all ?

[Artturi Alm]

On Fri, Jul 14, 2017 at 03:28:25AM +0300, Artturi Alm wrote:
> Hi,
> 
> i'm having hard time choosing, between this diff, and the one that
> renames it to for what it does, which would likely incur cleanup
> elsewhere. current is just wrong.. but i'm open to be taught on this
> matter anyway.
> 
> -Artturi
> 

Wonders of manually recreating a quick diff by hand above.. fixed:

diff --git a/sys/arch/arm/arm/cpufunc.c b/sys/arch/arm/arm/cpufunc.c
index c91108e7066..fd5385043fc 100644
--- a/sys/arch/arm/arm/cpufunc.c
+++ b/sys/arch/arm/arm/cpufunc.c
@@ -291,8 +291,8 @@ armv7_dcache_wbinv_all()
                for (ways = 0; ways < nways; ways++) {
                        word = wayval | setval | lvl;
 
-                       /* Clean D cache SE with Set/Index */
-                       __asm volatile("mcr     p15, 0, %0, c7, c10, 2"
+                       /* Data cache clean and invalidate by set/way */
+                       __asm volatile("mcr     p15, 0, %0, c7, c14, 2\n"
                            : : "r" (word));
                        wayval += wayincr;
                }