Hi, Per encouragement from deraadt@, here's a diff that explicitly discourages casting unused return values to void. The recent style.9 change from Matthew Martin deleted the last (void) cast in style.9, so I think it makes sense to formalize it.
Not sure if it needs further explanation along the lines of, "this was mainly done to appease lint(1), but now that we don't ship lint(1) it only makes code harder to read." If so, it might fit in better down at the end of the document after the bit about not using lint-style comments. Thoughts? -- Scott Cheloha Index: share/man/man9/style.9 =================================================================== RCS file: /cvs/src/share/man/man9/style.9,v retrieving revision 1.71 diff -u -p -r1.71 style.9 --- share/man/man9/style.9 10 Jul 2017 21:39:38 -0000 1.71 +++ share/man/man9/style.9 21 Jul 2017 21:49:14 -0000 @@ -514,6 +514,9 @@ Routines returning .Li void * should not have their return values cast to any pointer type. .Pp +Do not cast unused return values to +.Li void . +.Pp Use the .Xr err 3 and