On Fri, Jul 28, 2017 at 09:34:29PM +0200, Frederic Cambus wrote:
> Hi tech@,
>
> plog format string should be literal.
>
> Comments? OK?
OK
while you are in there, can you add format attributes to plog like our
log.h has (see usr.sbin/bgpd/log.h for example)
>
> Index: usr.sbin/amd/amd/ifs_ops.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/amd/amd/ifs_ops.c,v
> retrieving revision 1.5
> diff -u -p -r1.5 ifs_ops.c
> --- usr.sbin/amd/amd/ifs_ops.c 26 Oct 2014 02:43:50 -0000 1.5
> +++ usr.sbin/amd/amd/ifs_ops.c 28 Jul 2017 19:22:56 -0000
> @@ -63,7 +63,7 @@ ifs_init(mntfs *mf)
> {
> mntfs *mf_link = (mntfs *) mf->mf_private;
> if (mf_link == 0) {
> - plog(XLOG_FATAL, not_a_filesystem);
> + plog(XLOG_FATAL, "%s", not_a_filesystem);
> return EINVAL;
> }
> #ifdef notdef
> @@ -89,7 +89,7 @@ ifs_inherit(mntfs *mf)
> */
> mntfs *mf_link = (mntfs *) mf->mf_private;
> if (mf_link == 0) {
> - plog(XLOG_FATAL, not_a_filesystem);
> + plog(XLOG_FATAL, "%s", not_a_filesystem);
> return 0; /*XXX*/
> }
>
>
--
I'm not entirely sure you are real.
