On Fri, Jul 28, 2017 at 02:31:02PM +0000, Florian Obser wrote: > > pointed out by clang > > OK? >
comon, don't be shy, this is an easy one... maybe with a bit more context? This is an error return: diff --git usr.bin/systat/pool.c usr.bin/systat/pool.c index b6691ae0da6..3b289446522 100644 --- usr.bin/systat/pool.c +++ usr.bin/systat/pool.c @@ -492,14 +492,15 @@ pool_cache_read(void) return 0; unalloc: while (i > num_pool_caches) { pc = &pool_caches[--i]; free(pc->cache_cpus); } + return (-1); } -- I'm not entirely sure you are real.