Re: cwm: Don't ignore case when sorting exec menu

[Okan Demirmen]

On Sun, Sep 3, 2017 at 3:43 PM, <b...@lloyd.im> wrote:

> Hi tech@
> ​,
>

​Hi,
​

> ​
>
> I wasn't able to execute "zzz" (lower case) from the exec menu in cwm.
> It
> skipped over it when ordering the search results because "ZZZ" (upper
> case) was already there
> ​.
>

​Indeed, I agree that case matters here.
​

> ​
>
> This is my first patch, so please let me know if anything else is
> needed.
> ​
>

​Thanks!
​

> ​
>
> Thanks,
>
> Ben
>
>
> Index: app/cwm/search.c
> ===================================================================
> RCS file: /cvs/xenocara/app/cwm/search.c,v
> retrieving revision 1.62
> diff -u -p -r1.62 search.c
> --- app/cwm/search.c    25 Apr 2017 13:40:33 -0000      1.62
> +++ app/cwm/search.c    3 Sep 2017 19:21:44 -0000
> @@ -201,7 +201,7 @@ search_match_exec(struct menu_q *menuq,
>                     fnmatch(search, mi->text, 0) == FNM_NOMATCH)
>                         continue;
>                 TAILQ_FOREACH(mj, resultq, resultentry) {
> -                       r = strcasecmp(mi->text, mj->text);
> +                       r = strcmp(mi->text, mj->text);
>                         if (r < 0)
>                                 TAILQ_INSERT_BEFORE(mj, mi,
>                                 resultentry);
>                         if (r <= 0)
>
>