Actually, it should be more efficient to remove bzero() function
and keep set NULL-terminate char.
Best Regards
Nan Xiao
Index: pctr.c
===================================================================
RCS file: /cvs/src/usr.bin/pctr/pctr.c,v
retrieving revision 1.22
diff -u -p -r1.22 pctr.c
--- pctr.c 8 Feb 2015 23:40:34 -0000 1.22
+++ pctr.c 9 Sep 2017 14:05:17 -0000
@@ -166,7 +166,6 @@ pctr_cpu_creds(void)
mib[0] = CTL_HW;
mib[1] = HW_MACHINE;
len = sizeof(arch) - 1;
- bzero(arch, sizeof(arch));
if (sysctl(mib, 2, arch, &len, NULL, 0) == -1)
err(1, "HW_MACHINE");
arch[len] = '\0';
@@ -195,7 +194,6 @@ pctr_cpu_creds(void)
mib[0] = CTL_MACHDEP;
mib[1] = CPU_CPUVENDOR;
len = sizeof(vendor) - 1;
- bzero(vendor, sizeof(vendor));
if (sysctl(mib, 2, vendor, &len, NULL, 0) == -1)
err(1, "CPU_CPUVENDOR");
vendor[len] = '\0';
On 9/9/2017 11:56 AM, Nan Xiao wrote:
> Hi tech@,
>
> Remove setting null-terminated string operation, since bzero()
> has done this operation before. Sorry if I miss some points.
>
> Thanks!
>
> Best Regards
> Nan Xiao
>
> Index: pctr.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/pctr/pctr.c,v
> retrieving revision 1.22
> diff -u -p -r1.22 pctr.c
> --- pctr.c 8 Feb 2015 23:40:34 -0000 1.22
> +++ pctr.c 9 Sep 2017 03:43:36 -0000
> @@ -169,7 +169,6 @@ pctr_cpu_creds(void)
> bzero(arch, sizeof(arch));
> if (sysctl(mib, 2, arch, &len, NULL, 0) == -1)
> err(1, "HW_MACHINE");
> - arch[len] = '\0';
>
> if (strcmp(arch, "i386") == 0)
> atype = ARCH_I386;
> @@ -198,7 +197,6 @@ pctr_cpu_creds(void)
> bzero(vendor, sizeof(vendor));
> if (sysctl(mib, 2, vendor, &len, NULL, 0) == -1)
> err(1, "CPU_CPUVENDOR");
> - vendor[len] = '\0';
>
> switch (atype) {
> case ARCH_I386:
>
