On 11/10/17(Wed) 12:28, Alexandr Nedvedicky wrote:
> Hello,
>
> just for my curiosity:
>
> why do you leave some returns untreated? is that intentional?
Yes it is intentional to make the diff shorter and easier to review.
> just like here:
> @@ -2048,8 +2048,11 @@ ifioctl(struct socket *so, u_long cmd, caddr_t
> data, struct proc *p)
> case SIOCGVNETID:
> case SIOCGIFPAIR:
> case SIOCGIFPARENT:
> - if (ifp->if_ioctl == 0)
> - return (EOPNOTSUPP);
> + if (ifp->if_ioctl == 0) {
> + /* ??? sashan@ */
> + error = EOPNOTSUPP;
> + break;
> + }
> error = (*ifp->if_ioctl)(ifp, cmd, data);
> break;
This will be addressed in the next diff. We can simply remove the if ()
block because all interface MUST have an if_ioctl handler.
