On Tue, 14 Nov 2017 09:26:47 +0100, Theo Buehler wrote: > If we only support UTF-8 and ASCII, we do not need complicated multibyte > decoding to recognize a '%' in the format string. > > In his commit message, enh claims that there is a 10x speedup. In my own > benchmarking on amd64, a speedup between 1.5x and 5x seems to be more > realistic. The code does get significantly simpler, so I think it might > be worth it.
I think we do want this change. I've seen run-time failures before due to that code when using snprintf() to write binary data to a string without a format string caused by mbrtowc() returning an error. - todd
