On 2017/11/27 11:22, Peter Hessler wrote:
> :retrieving revision 1.319
> :diff -u -p -r1.319 ip_carp.c
> :--- netinet/ip_carp.c        21 Nov 2017 09:08:55 -0000      1.319
> :+++ netinet/ip_carp.c        27 Nov 2017 01:29:34 -0000
> :@@ -2158,9 +2158,8 @@ carp_ioctl(struct ifnet *ifp, u_long cmd
> :             }
> :             carpr.carpr_advbase = sc->sc_advbase;
> :             carpr.carpr_balancing = sc->sc_balancing;
> :-            if (suser(p, 0) == 0)
> :-                    bcopy(sc->sc_key, carpr.carpr_key,
> :-                        sizeof(carpr.carpr_key));
> :+            /* do not show any keys to userland */
> :+            memset(carpr.carpr_key, 0, sizeof(carpr.carpr_key));
> :             carpr.carpr_peer.s_addr = sc->sc_peer.s_addr;
> :             error = copyout(&carpr, ifr->ifr_data, sizeof(carpr));
> :             break;
> :
> 
> Best I can tell, ifconfig carp doesn't tell you the key anyways, so OK.

ifconfig doesn't. shells/nsh will be a bit of a pain to fix though.

Reply via email to