On 28/11/17(Tue) 17:40, Otto Moerbeek wrote: > On Tue, Nov 28, 2017 at 10:59:07PM +0800, Helg wrote: > > One small comment from me: > > > /* already open i think all is ok */ > > if (ip->fufh[fufh_type].fh_type != FUFH_INVALID) > > return (0); > > > > + /* > > + * The file has already been created and/or truncated so FUSE dictates > > + * that no creation and truncation flags are passed to open. > > + */ > > + flags = OFLAGS(ap->a_mode) & ~(O_CREAT|O_EXCL|O_TRUNC); > > + > > error = fusefs_file_open(fmp, ip, fufh_type, flags, isdir, ap->a_p); > > if (error) > > return (error); > > > > - return (error); > > + return (0); > > Just return (error) after the fusefs_file_open() call.
ok mpi@ with that.
