Hello,
On Thu, Nov 30, 2017 at 06:09:16PM +0100, Alexander Bluhm wrote:
> Hi,
>
> I would like to simplify the reverse pcb lookup logic. The
> PF_TAG_TRANSLATE_LOCALHOST security check predates the divert
> feature. It prevents that you accidentally use redirect where a
> divert-to would be appropriate.
>
> Instead of spreading the logic into tcp and udp input, we could
> just check the flag during pcb listen lookup. This also reduces
> parameters of in_pcblookup_listen().
>
> I also cleaned up the #if, if, else if, else logic in
> in_pcblookup_listen(). Set the default in front, do the special
> pf things afterwards.
>
> ok?
>
no objections, change looks good to me.
OK sashan
