> Date: Mon, 4 Dec 2017 21:39:43 -0800 > From: Philip Guenther <[email protected]> > > On Mon, 4 Dec 2017, Mark Kettenis wrote: > > The ld.so bits have been committed last week. So here is a new version > > of the diff. This version exports __cxa_thread_atexit_impl such that > > gcc picks up our implementation. __cxa_thread_atexit becomes a weak > > alias such that static linking succeeds. I rebuilt the gcc 4.9 port > > with this diff and verified that it does indeed run the new code. > > Per our discussion on the trail to the Lower Elk lake overlook, I think > you should leave out the #ifndef NO_PIC/#endif around the call to dlctl() > in __cxa_thread_atexit_impl(): NO_PIC is never defined in libc and we > don't really have an interest in optimizing for a future arch that doesn't > support shared libs.
Ah. I missed that bit. Thanks for spotting this.
