On Thu, 14 Dec 2017, Mark Kettenis wrote: > Diff below makes sure libutil doesn't export any unwanted symbols. The > immediate motivation here is to prevent exportong certain libgcc symbols > on armv7 that cause issues when switching from gcc to clang. > > With this diff, only symbols present in man pages and public header > files are exported. A few helper functions are made static. The one > exception is imsg_fd_overhead which according to the relevant commit > message is intended as a public API. Note that this API isn't actually > used in our tree. Also note that global variables like this are bad API > design. > > The check_syms script gives the following output: > > /usr/lib/libutil.so.12.2 --> obj/libutil.so.13.0 > Dynamic export changes: > removed: > __bss_start > __data_start > _edata > _end > _fini > _init > ibuf_dequeue > ibuf_enqueue > ibuf_realloc > imsg_get_fd > > ok?
Nice. ok guenther@
