On Wed, Dec 20, 2017 at 04:10:15PM +0100, Jeremie Courreges-Anglas wrote: > > Diff on top of Symbols.map addition, using the same tools as other libs. > > check_sym output: > /usr/lib/libsndio.so.7.0 --> obj/libsndio.so.7.0 > No dynamic export changes > PLT removed: > mio_rmidi_getfd > sio_revents > sio_sun_fdopen > sio_sun_getfd > > I have already discussed a similar diff with Alexandre, who doesn't like > much the additional lines. I'm not sure how easily this can be crammed > into the portable version. > > Thoughts? ok?
my "dissatisfaction" was mosty about "it doesn't look like C" and my lack of understanding of the benefit of removing these 4 PLT entries. There's no code that would override one of above symbols, so removing the PTL wont break anything. If this is the way we handle all base libs, i'm of course OK with that change (tested & it works) and the portable libsndio can be fixed with a little #ifdefery.
