> Date: Thu, 21 Dec 2017 13:01:31 +0200 > From: Paul Irofti <p...@irofti.net> > > If no one objects, I will commit this tomorrow.
Fix is wrong since it will break with gcc. Probably best to just use %02x, just like we did for printing duids. > On Tue, Dec 19, 2017 at 11:14:19PM +0200, Paul Irofti wrote: > > Hi, > > > > I am currently trying to fix dual-monitor support for Intel HD Graphics 520. > > The following fixes the build when DRM_DEBUG is enabled. OK? > > > > Paul > > > > > > Index: dev/pci/drm/i915/intel_dp.c > > =================================================================== > > RCS file: /cvs/src/sys/dev/pci/drm/i915/intel_dp.c,v > > retrieving revision 1.29 > > diff -u -p -u -p -r1.29 intel_dp.c > > --- dev/pci/drm/i915/intel_dp.c 30 Sep 2017 07:36:56 -0000 1.29 > > +++ dev/pci/drm/i915/intel_dp.c 19 Dec 2017 21:10:42 -0000 > > @@ -4056,11 +4056,11 @@ intel_dp_probe_oui(struct intel_dp *inte > > return; > > > > if (intel_dp_dpcd_read_wake(&intel_dp->aux, DP_SINK_OUI, buf, 3) == 3) > > - DRM_DEBUG_KMS("Sink OUI: %02hx%02hx%02hx\n", > > + DRM_DEBUG_KMS("Sink OUI: %02hhx%02hhx%02hhx\n", > > buf[0], buf[1], buf[2]); > > > > if (intel_dp_dpcd_read_wake(&intel_dp->aux, DP_BRANCH_OUI, buf, 3) == 3) > > - DRM_DEBUG_KMS("Branch OUI: %02hx%02hx%02hx\n", > > + DRM_DEBUG_KMS("Branch OUI: %02hhx%02hhx%02hhx\n", > > buf[0], buf[1], buf[2]); > > } > > > > Index: dev/pci/drm/radeon/atombios_dp.c > > =================================================================== > > RCS file: /cvs/src/sys/dev/pci/drm/radeon/atombios_dp.c,v > > retrieving revision 1.7 > > diff -u -p -u -p -r1.7 atombios_dp.c > > --- dev/pci/drm/radeon/atombios_dp.c 1 Jul 2017 16:14:10 -0000 > > 1.7 > > +++ dev/pci/drm/radeon/atombios_dp.c 19 Dec 2017 21:10:42 -0000 > > @@ -373,11 +373,11 @@ static void radeon_dp_probe_oui(struct r > > return; > > > > if (drm_dp_dpcd_read(&radeon_connector->ddc_bus->aux, DP_SINK_OUI, buf, > > 3) == 3) > > - DRM_DEBUG_KMS("Sink OUI: %02hx%02hx%02hx\n", > > + DRM_DEBUG_KMS("Sink OUI: %02hhx%02hhx%02hhx\n", > > buf[0], buf[1], buf[2]); > > > > if (drm_dp_dpcd_read(&radeon_connector->ddc_bus->aux, DP_BRANCH_OUI, > > buf, 3) == 3) > > - DRM_DEBUG_KMS("Branch OUI: %02hx%02hx%02hx\n", > > + DRM_DEBUG_KMS("Branch OUI: %02hhx%02hhx%02hhx\n", > > buf[0], buf[1], buf[2]); > > } > > > >