> Date: Thu, 21 Dec 2017 13:06:00 +0100
> From: Martin Ziemer <[email protected]>
>
> My system crashed regularly on usage of graphical Browsers. Other
> people had the same issues:
> https://marc.info/?l=openbsd-misc&m=150916174632762&w=2
>
> After searching for the problem I found the solution in DragonflyBSD
> and ported those changes to our inteldrm:
> https://www.mail-archive.com/[email protected]/msg157533.html
>
> The patch fixed the issue not only for me, but for at least two other
> users.
>
> Could someone please apply those changes to our inteldrm? (Or tell me,
> why those changes are not fitting)
Sorry. I want to test this myself before I commit it, but I keep
getting distracted with other stuff.
That said, the first bit (pt_vaddr) looks correct, but the second bit
doesn't make sense. Have you actually seen the WARM_ON(!pt) being
triggered?
> Index: i915_gem_gtt.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/drm/i915/i915_gem_gtt.c,v
> retrieving revision 1.15
> diff -u -p -r1.15 i915_gem_gtt.c
> --- i915_gem_gtt.c 1 Jul 2017 16:14:10 -0000 1.15
> +++ i915_gem_gtt.c 16 Nov 2017 15:51:02 -0000
> @@ -778,7 +778,10 @@ static void gen8_ppgtt_clear_pte_range(s
> num_entries--;
> }
>
> - kunmap_px(ppgtt, pt);
> + kunmap_px(ppgtt, pt_vaddr); /* XXX dillon, out of order
> + * patch from linux
> + * 44a71024 12-Apr-2016
> + */
>
> pte = 0;
> if (++pde == I915_PDES) {
> @@ -1317,6 +1320,8 @@ static int gen8_alloc_va_range_3lvl(stru
> gen8_for_each_pde(pt, pd, pd_start, pd_len, temp, pde) {
> /* Same reasoning as pd */
> WARN_ON(!pt);
> + if (pt == NULL) /* XXX dillon hack */
> + continue; /* XXX dillon hack */
> WARN_ON(!pd_len);
> WARN_ON(!gen8_pte_count(pd_start, pd_len));
>
>
