We used to try to create ifconfig output that someone could cut'n'paste
back in as input, when it was reasonable.  Therefore ifconfig output
was a human hint suggesting what ifconfig command takes as input.

But this one doesn't bother me, since for this line it doesn't work
and making it shorter will make the lines cleaner.

Same thing for nwkey?

> We're no longer exporting keys to userland, so can we stop printing
> "<not displayed>"?
> 
> ok?
> 
> Index: ifconfig.c
> ===================================================================
> RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v
> retrieving revision 1.351
> diff -u -p -r1.351 ifconfig.c
> --- ifconfig.c        17 Nov 2017 18:04:51 -0000      1.351
> +++ ifconfig.c        6 Jan 2018 13:59:33 -0000
> @@ -2181,13 +2181,8 @@ ieee80211_status(void)
>               }
>       }
>  
> -     if (ipsk == 0 && psk.i_enabled) {
> -             fputs(" wpakey ", stdout);
> -             if (psk.i_enabled == 2)
> -                     fputs("<not displayed>", stdout);
> -             else
> -                     print_string(psk.i_psk, sizeof(psk.i_psk));
> -     }
> +     if (ipsk == 0 && psk.i_enabled)
> +             fputs(" wpakey", stdout);
>       if (iwpa == 0 && wpa.i_enabled) {
>               const char *sep;
>  
> 

Reply via email to