On Mon, Jan 08, 2018 at 10:53:48AM +0800, Michael W. Bombardieri wrote:
> Hello,
> 
> I noticed that calls to the function bwfm_pci_debug_console() 
> are wrapped in ifdef but the function itself isn't.
> 
> - Michael

Fixed that and also changed it so it only prints it when we're
running with a higher debug mode.  Thanks!

> 
> Index: if_bwfm_pci.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/if_bwfm_pci.c,v
> retrieving revision 1.8
> diff -u -p -u -r1.8 if_bwfm_pci.c
> --- if_bwfm_pci.c     8 Jan 2018 00:46:15 -0000       1.8
> +++ if_bwfm_pci.c     8 Jan 2018 02:29:14 -0000
> @@ -255,7 +255,9 @@ void               bwfm_pci_flowring_delete(struct b
>  
>  void          bwfm_pci_stop(struct bwfm_softc *);
>  int           bwfm_pci_txdata(struct bwfm_softc *, struct mbuf *);
> +#ifdef BWFM_DEBUG
>  void          bwfm_pci_debug_console(struct bwfm_pci_softc *);
> +#endif
>  
>  int           bwfm_pci_msgbuf_query_dcmd(struct bwfm_softc *, int,
>                   int, char *, size_t *);
> @@ -1666,6 +1668,7 @@ bwfm_pci_txdata(struct bwfm_softc *bwfm,
>       return 0;
>  }
>  
> +#ifdef BWFM_DEBUG
>  void
>  bwfm_pci_debug_console(struct bwfm_pci_softc *sc)
>  {
> @@ -1685,6 +1688,7 @@ bwfm_pci_debug_console(struct bwfm_pci_s
>               printf("%c", ch);
>       }
>  }
> +#endif 
>  
>  int
>  bwfm_pci_intr(void *v)
> 

Reply via email to