On Sat, Jan 20, 2018 at 11:19:22AM +0100, Matthieu Herrb wrote: > Hi, > > I'm not sure if the __VFP_FP__ section below was still useful for gcc > builds, at lead it doesn't build and doesn't look needed with clang > (the functions are all provied by libcompiler_rt, which is included). > > ok ?
The __VFP_FP__ block seems to be a local change that predates xenocara 1.1 can we just remove it? Added in XF4 1.4 ---------------------------- revision 1.4 date: 2004/06/16 16:04:12; author: todd; state: Exp; lines: +113 -574; add cats support from drahn@ (thanks!) ---------------------------- > > Index: hw/xfree86/os-support/bsd/arm_video.c > =================================================================== > RCS file: > /cvs/OpenBSD/xenocara/xserver/hw/xfree86/os-support/bsd/arm_video.c,v > retrieving revision 1.14 > diff -u -p -u -r1.14 arm_video.c > --- hw/xfree86/os-support/bsd/arm_video.c 28 Sep 2015 07:14:00 -0000 > 1.14 > +++ hw/xfree86/os-support/bsd/arm_video.c 20 Jan 2018 10:17:09 -0000 > @@ -88,7 +88,8 @@ xf86PrivilegedInit(void) > xf86OpenConsole(); > } > > -#ifdef __VFP_FP__ > + > +#if defined(__VFP_FP__) && !defined(__clang__) > /* > * force softfloat functions into binary, > * yes the protos/ret are all bogus. > @@ -149,4 +150,5 @@ __subdf3(); > __subsf3(); > __truncdfsf2(); > } > -#endif /* __VFP_FP__ */ > +#endif /* __VFP_FP__ && !__clang__ */ > + > > -- > Matthieu Herrb >
