On Tue, Jan 23, 2018 at 03:23:24PM +0100, Martin Pieuchot wrote: > On 23/01/18(Tue) 14:06, Visa Hankala wrote: > > In addition, you should put the common mutex code into kern_mutex.c. > > Lets keep kern_lock.c for the mplock only. > > I'm more in favor of putting everything into kern_lock.c. We're talking > about less than 400 lines of code.
To me this seems a bit odd at the moment, but fine. > +#ifdef MP_LOCKDEBUG > +#ifndef DDB > +#error "MP_LOCKDEBUG requires DDB" > +#endif > + > +/* CPU-dependent timing, needs this to be settable from ddb. */ > +extern int __mp_lock_spinout; > +#endif The above should be left out. There already is a similar block at the start of the file. Otherwise OK visa@.
