On Fri, Jan 26, 2018 at 05:38:46PM +0000, Stuart Henderson wrote:
> On 2018/01/26 18:12, Florian Obser wrote:
> > anyone else?
> > Got around to read the diff, not too much insanity in there, going to
> > commit soon.
>
> ok with me.
>
> > diff --git nsd.c nsd.c
> > index f2cf6ccf0cb..dfbc58696b3 100644
> > --- nsd.c
> > +++ nsd.c
> > @@ -579,6 +579,7 @@ main(int argc, char *argv[])
> > case 'v':
> > version();
> > /* version exits */
> > + break;
> > #ifndef NDEBUG
> > case 'F':
> > sscanf(optarg, "%x", &nsd_debug_facilities);
> > @@ -980,6 +981,7 @@ main(int argc, char *argv[])
> > break;
> > case -1:
> > error("fork() failed: %s", strerror(errno));
> > + break;
> > default:
> > /* Parent is done */
> > server_close_all_sockets(nsd.udp, nsd.ifs);
>
> that gcc lint thing doesn't seem particularly clever if those are needed!
>
Indeed, there is also some comment spam that's not relevant for us, I
left that in to not create conflicts for future updates.
I like this one :D
/** Fallthrough: AXFR over UDP queries are discarded. */
+ /* fallthrough */
I dropped this though:
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
Don't want to find out in two weeks time what gcc on the luna88k
thinks about that...
--
I'm not entirely sure you are real.
