On Fri, Mar 09, 2018 at 09:08:17PM +0100, Mark Kettenis wrote:
> 
> I only got positive feedback.  So here is a diff that also works on
> gcc architectures and has some regress tests.  Oh, and there is a man
> page as well.
> 
> ok?
> 

hi.

- there is a lot of trailing whitespace in the man diff. please zap it.
- it probably wants $OpenBSD$
- the comma after the sin Xr in SEE ALSO should be removed
- consider adding Xr to this page in the cos/sin pages
- "the memory pointed to by *s and *c are assigned the values" would
  read better as *is* assigned, i think.

we can fix that in-tree if it's easier.

jmc

> 
> Index: lib/libm/man/sincos.3
> ===================================================================
> RCS file: lib/libm/man/sincos.3
> diff -N lib/libm/man/sincos.3
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ lib/libm/man/sincos.3     9 Mar 2018 20:05:01 -0000
> @@ -0,0 +1,77 @@
> +.\" Copyright (c) 2011 Steven G. Kargl.
> +.\"
> +.\" Redistribution and use in source and binary forms, with or without
> +.\" modification, are permitted provided that the following conditions
> +.\" are met:
> +.\" 1. Redistributions of source code must retain the above copyright
> +.\"    notice, this list of conditions and the following disclaimer.
> +.\" 2. Redistributions in binary form must reproduce the above copyright
> +.\"    notice, this list of conditions and the following disclaimer in the
> +.\"    documentation and/or other materials provided with the distribution.
> +.\"
> +.\" THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
> +.\" ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> +.\" IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
> PURPOSE
> +.\" ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
> +.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
> CONSEQUENTIAL
> +.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> +.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> +.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, 
> STRICT
> +.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> +.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> +.\" SUCH DAMAGE.
> +.\"
> +.\" $FreeBSD: head/lib/msun/man/sincos.3 319047 2017-05-28 06:13:38Z mmel $
> +.\"
> +.Dd $Mdocdate$
> +.Dt SINCOS 3
> +.Os
> +.Sh NAME
> +.Nm sincos ,
> +.Nm sincosf ,
> +.Nm sincosl
> +.Nd sine and cosine functions
> +.Sh SYNOPSIS
> +.In math.h
> +.Ft void
> +.Fn sincos "double x" "double *s" "double *c"
> +.Ft void
> +.Fn sincosf "float x" "float *s" "float *c"
> +.Ft void
> +.Fn sincosl "long double x" "long double *s" "long double *c"
> +.Sh DESCRIPTION
> +The
> +.Fn sincos ,
> +.Fn sincosf ,
> +and
> +.Fn sincosl
> +functions compute the sine and cosine of
> +.Fa x .
> +Using these functions allows argument reduction to occur only
> +once instead of twice with individual invocations of 
> +.Fn sin
> +and 
> +.Fn cos .
> +Like 
> +.Fn sin
> +and 
> +.Fn cos ,
> +a large magnitude argument may yield a result with little
> +or no significance.
> +.Sh RETURN VALUES
> +Upon returning from 
> +.Fn sincos ,
> +.Fn sincosf ,
> +and
> +.Fn sincosl ,
> +the memory pointed to by 
> +.Ar "*s" 
> +and
> +.Ar "*c" 
> +are assigned the values of sine and cosine, respectively.
> +.Sh SEE ALSO
> +.Xr cos 3 ,
> +.Xr sin 3 ,
> +.Sh HISTORY
> +These functions first appeared in
> +.Ox 6.3 .

Reply via email to