On Mon, Apr 16, 2018 at 12:13:10AM +0300, IL Ka wrote:
> Links to appropriate man pages added
> 

this doesn;t apply cleanly, so i'll comment: i'm ok with adding the
links. still, we have a mix of

        See blah(x) for details.
and
        See blah(x).

i think less is more here, so maybe you can resubmit a diff which
changes *all* refs to just "See blah(4)."

one more comment inline:

> 
> diff --git share/man/man4/options.4 share/man/man4/options.4
> index 9ef493cf6..cf146d9a7 100644
> --- share/man/man4/options.4
> +++ share/man/man4/options.4
> @@ -309,6 +309,9 @@ in large directories.
>  Provide in-kernel support for controlling VGA framebuffer mapping
>  and PCI configuration registers by user-processes
>  (such as an X Window System server).
> +See
> +.Xr xf86 4
> +for details.
>  This option is supported on the
>  .Va alpha ,
>  .Va amd64 ,
> @@ -323,6 +326,9 @@ Adds support for the
>  boot option (User Kernel Config).
>  Allows modification of kernel settings (e.g., device parameters) before
>  booting the system.
> +See
> +.Xr boot_config 8
> +for details.
>  .It Cd option CRYPTO
>  Enables support for the kernel cryptographic framework.
>  See
> @@ -332,6 +338,9 @@ While not IP specific, this option is usually used in
> conjunction with option
>  .Em IPSEC .
>  .It Cd option EISAVERBOSE
>  Makes the boot process more verbose for EISA peripherals.
> +See
> +.Xr eisa 4
> +for details.
>  .It Cd option KMEMSTATS
>  The kernel memory allocator,
>  .Xr malloc 9 ,
> @@ -341,8 +350,14 @@ On those architectures that have it, this enables
> multiprocessor support.
>  .It Cd option PCIVERBOSE
>  Makes the boot process more verbose for PCI peripherals
>  (vendor names and other information is printed, etc.).
> +See
> +.Xr pci 4
> +for details
>  .It Cd option PCMCIAVERBOSE
>  Makes the boot process more verbose for PCMCIA peripherals.
> +See
> +.Xr pcmcia 4
> +for details.
>  .It Cd option USER_PCICONF
>  Enables the user level access to the PCI bus configuration space
>  through ioctls on the
> @@ -350,7 +365,9 @@ through ioctls on the
>  device.
>  It's used by the
>  .Xr Xorg 1
> -server on some architectures.
> +server on some architectures,
> +.Xr pcidump 8
> +uses it also.

i would cut this to

        It's used by
        .Xr Xorg 1
        and
        .Xr pcidump 8 .

jmc

>  See
>  .Xr pci 4
>  for details.
> @@ -511,6 +528,9 @@ Double quotes are needed when specifying a negative
>  .Ar value .
>  .El
>  .Sh SCSI SUBSYSTEM OPTIONS
> +See
> +.Xr scsi 4
> +for details.
>  .Bl -ohang
>  .It Cd option SCSI_DELAY= Ns Ar value
>  Delay for

Reply via email to