> On Sun, Apr 29, 2018 at 09:42:00AM +0000, Miod Vallat wrote: > > > > > Don't use attr uninitialised. Avoids glitches seen when using > > > scrollback with radeondrm. > > > > That's horrible. The bg attribute should be passed to the function, > > rather than computed here with possibly wrong values. > > > > You didn't include a diff so I guess you propose something like this?
I'm not sure this is correct, but that's probably better. My point is that, if you need to erase a few rows, you need to use the default (non kernel) background attribute. This attribute depends from the wsdisplay emulation in use (it's edp->defattr). But since the emulation is the one asking for scrollback, it should be easy to plumb it down the way - adding an extra argument to the .scrollback wsdisplay_accessops and then to rasops_scrollback().
