On Mon, 07 May 2018 19:21:37 +0200, Alexander Bluhm wrote: > When looping over mount points, the FOREACH SAVE macro is not save. > The loop variable mp is protected by vfs_busy() so that it cannot > be unmounted. But the next mount point nmp could be unmounted while > VFS_SYNC() sleeps. As the loop in vfs_stall() does not destroy the > mount point, TAILQ_FOREACH_REVERSE without _SAVE is the correct > macro to use.
I think this deserves a comment so someone else doesn't try to "fix" it later. - todd
