On Sat, Jun 02, 2018 at 11:30:15AM +0000, Visa Hankala wrote: > On Sat, Jun 02, 2018 at 01:00:05PM +0200, Frederic Cambus wrote: > > Hi tech@, > > > > Here is a diff to remove unused C3 values. > > > > Comments? OK? > > I would keep the definitions because they can at least serve as a weak > form of documentation about the hardware. For example, > C3_CRYPT_CWLO_ALG_M indicates what bits specify the algorithm, which > in turn helps one to understand the value of C3_CRYPT_CWLO_ALG_AES.
Agreed. That makes sense indeed, sorry for the noise.