On Sun, Jun 03 2018, Alexander Bluhm <alexander.bl...@gmx.net> wrote:
> On Sun, Jun 03, 2018 at 12:26:18AM +0200, Klemens Nanni wrote:
>> With `make ROUTE=/usr/obj/sbin/route/route' I can test my patched
>> version without having to modify PATH or the regress Makefile. 
>> 
>> pfctl already does it that way.
>
> This is the right approach.
>
>> OK?
>
> I prefer ROUTE ?= /sbin/route, then regress does not depend on the
> PATH.  It is clear in the output which route is used.
>
> with that OK bluhm@

ditto

>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/src/regress/sbin/route/Makefile,v
>> retrieving revision 1.29
>> diff -u -p -r1.29 Makefile
>> --- Makefile 20 Feb 2018 12:44:28 -0000      1.29
>> +++ Makefile 2 Jun 2018 22:13:25 -0000
>> @@ -1,5 +1,6 @@
>>  # $OpenBSD: Makefile,v 1.29 2018/02/20 12:44:28 mpi Exp $
>>  
>> +ROUTE?=             route
>>  RDOMAIN?=   5
>>  
>>  .MAIN: all
>> @@ -27,7 +28,7 @@ RDOMAIN?=  5
>>  .endif
>>  .endif
>>  
>> -RCMD=               ${SUDO} route -T ${RDOMAIN} -n
>> +RCMD=               ${SUDO} ${ROUTE} -T ${RDOMAIN} -n
>>  
>>  netmask:
>>  .for mod in -net -dst
>

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to