Hi Philip,

Thanks for your comments!

On 6/9/2018 12:35 PM, Philip Guenther wrote:
> On Thu, Jun 7, 2018 at 12:34 AM Nan Xiao <n...@chinadtrace.org
> <mailto:n...@chinadtrace.org>> wrote:
>     I think maybe one snprintf is more efficient and concise. Sorry if I am
>     wrong, thanks!
> Seems unlikely.  More productive would be to go up a level and look at
> whether concat() is carrying its weight as an abstraction.  One of the
> calls is completely superfluous, to my eye.
> But really, ldconfig is pretty uninteresting, being run very, very
> rarely, so polishing it is like sanding the rough spots on the bottoms
> of table legs, where they touch the floor.  We've spent more cycles
> talking about it then it'll use in a year...
> Philip Guenther

Best Regards
Nan Xiao(肖楠)

Reply via email to