On Tue, Jul 03, 2018 at 04:27:30PM +0800, Kevin Lo wrote:
> Diff below replaces hand rolled code with LIST_FOREACH. ok?
OK bluhm@
> Index: sys/dev/ic/smc83c170.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/ic/smc83c170.c,v
> retrieving revision 1.27
> diff -u -p -u -p -r1.27 smc83c170.c
> --- sys/dev/ic/smc83c170.c 22 Jan 2017 10:17:38 -0000 1.27
> +++ sys/dev/ic/smc83c170.c 3 Jul 2018 08:15:56 -0000
> @@ -1443,8 +1443,7 @@ epic_mediachange(struct ifnet *ifp)
> }
>
> /* Lookup selected PHY */
> - for (miisc = LIST_FIRST(&mii->mii_phys); miisc != NULL;
> - miisc = LIST_NEXT(miisc, mii_list)) {
> + LIST_FOREACH(miisc, &mii->mii_phys, mii_list) {
> if (IFM_INST(media) == miisc->mii_inst)
> break;
> }
> Index: sys/dev/usb/if_aue.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/if_aue.c,v
> retrieving revision 1.107
> diff -u -p -u -p -r1.107 if_aue.c
> --- sys/dev/usb/if_aue.c 3 Jul 2018 00:49:14 -0000 1.107
> +++ sys/dev/usb/if_aue.c 3 Jul 2018 08:15:58 -0000
> @@ -1396,9 +1396,8 @@ aue_ifmedia_upd(struct ifnet *ifp)
> sc->aue_link = 0;
> if (mii->mii_instance) {
> struct mii_softc *miisc;
> - for (miisc = LIST_FIRST(&mii->mii_phys); miisc != NULL;
> - miisc = LIST_NEXT(miisc, mii_list))
> - mii_phy_reset(miisc);
> + LIST_FOREACH(miisc, &mii->mii_phys, mii_list)
> + mii_phy_reset(miisc);
> }
> mii_mediachg(mii);
>
> Index: sys/dev/usb/if_udav.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/if_udav.c,v
> retrieving revision 1.79
> diff -u -p -u -p -r1.79 if_udav.c
> --- sys/dev/usb/if_udav.c 22 Jan 2017 10:17:39 -0000 1.79
> +++ sys/dev/usb/if_udav.c 3 Jul 2018 08:15:58 -0000
> @@ -1303,8 +1303,7 @@ udav_ifmedia_change(struct ifnet *ifp)
>
> if (mii->mii_instance) {
> struct mii_softc *miisc;
> - for (miisc = LIST_FIRST(&mii->mii_phys); miisc != NULL;
> - miisc = LIST_NEXT(miisc, mii_list))
> + LIST_FOREACH(miisc, &mii->mii_phys, mii_list)
> mii_phy_reset(miisc);
> }
>
> Index: sys/dev/usb/if_url.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/if_url.c,v
> retrieving revision 1.82
> diff -u -p -u -p -r1.82 if_url.c
> --- sys/dev/usb/if_url.c 22 Jan 2017 10:17:39 -0000 1.82
> +++ sys/dev/usb/if_url.c 3 Jul 2018 08:15:59 -0000
> @@ -1160,8 +1160,7 @@ url_ifmedia_change(struct ifnet *ifp)
> sc->sc_link = 0;
> if (mii->mii_instance) {
> struct mii_softc *miisc;
> - for (miisc = LIST_FIRST(&mii->mii_phys); miisc != NULL;
> - miisc = LIST_NEXT(miisc, mii_list))
> + LIST_FOREACH(miisc, &mii->mii_phys, mii_list)
> mii_phy_reset(miisc);
> }
>
