Since the RIBs have been fully split there is no way that an update of a
Loc-RIB is modifying the Adj-RIB-In. Because of that there is no need
for the comment and also for the more complex loop construct.
--
:wq Claudio
Index: rde.c
===================================================================
RCS file: /cvs/src/usr.sbin/bgpd/rde.c,v
retrieving revision 1.402
diff -u -p -r1.402 rde.c
--- rde.c 27 Jul 2018 12:03:17 -0000 1.402
+++ rde.c 27 Jul 2018 13:22:34 -0000
@@ -2843,7 +2842,7 @@ rde_softreconfig_in(struct rib_entry *re
{
struct filterstate state;
struct rib_desc *rib = ptr;
- struct prefix *p, *np;
+ struct prefix *p;
struct pt_entry *pt;
struct rde_peer *peer;
struct rde_aspath *asp;
@@ -2852,12 +2851,7 @@ rde_softreconfig_in(struct rib_entry *re
pt = re->prefix;
pt_getaddr(pt, &addr);
- for (p = LIST_FIRST(&re->prefix_h); p != NULL; p = np) {
- /*
- * prefix_remove() and path_update() may change the object
- * so cache the values.
- */
- np = LIST_NEXT(p, rib_l);
+ LIST_FOREACH(p, &re->prefix_h, rib_l) {
asp = prefix_aspath(p);
peer = asp->peer;
