Hi, thanks for your diff.
Ross L Richardson([email protected]) on 2018.07.30 11:25:08 +1000: > > [This diff is very similar to one I sent previously off-list to a few.] > > Just some style(9) and simple cleanup: > - order getopt string and switch cases commited, left f: at the end so its the same as in usage and manpage. > - add space between "if" and "(" > - wrap a long line > - return rather than exit() from main() commited. > - move chngdir == NULL test to where it belongs modified a bit. > - is there any reason > 404 /* Jail: sandbox, file-system, user. */ > 405 > 406 if (pledge("stdio", NULL) == -1) { > 407 warn("pledge"); > 408 exit(EXIT_FAILURE); > 409 } > 410 > shouldn't just use err() ? now its if (pledge("stdio", NULL) == -1) err(EXIT_FAILURE, "pledge"); > If so, then the exit() should still be return, shouldn't it? no, if you use err() there is no need for return. > - should the exit() calls from the various forked child processes > be _exit()? maybe.
