On Mon, Aug 13, 2018 at 07:01:25PM +0200, Jeremie Courreges-Anglas wrote: > On Mon, Aug 13 2018, Scott Cheloha <[email protected]> wrote: > > tb@ spotted this one. > > > > If BIO_new fails we leak scon, so SSL_free it in that case. > > > > ok? > > Alternative proposal: let doConnection() and benchmark() free the > resources they allocated respectively. >
I'd be ok with that as a workaround, but it doesn't change the fact that doConnection() desperately needs a cleanup. As Joel pointed out off-list, it would probably be better to to move the call to SSL_new() out of doConnection() and then simplify the latter. Cheloha is looking into that, and I think we can give this a bit of time.
