The -Wshadow warning was briefly enabled, but it turned out to break vax
builds with gcc3. Among other things, this warning helps catching stupid
mistakes in refactoring early, so I was wondering whether we could
re-enable it. The commit that disabled it also mentions gcc3, so I'm
unsure whether luna88k would be affected by this.

Index: usr.bin/openssl/Makefile
===================================================================
RCS file: /var/cvs/src/usr.bin/openssl/Makefile,v
retrieving revision 1.10
diff -u -p -r1.10 Makefile
--- usr.bin/openssl/Makefile    13 Aug 2017 19:42:33 -0000      1.10
+++ usr.bin/openssl/Makefile    22 Aug 2018 18:42:29 -0000
@@ -11,7 +11,7 @@ CFLAGS+= -Wformat
 CFLAGS+= -Wformat-security
 CFLAGS+= -Wimplicit
 CFLAGS+= -Wreturn-type
-#CFLAGS+= -Wshadow
+CFLAGS+= -Wshadow
 CFLAGS+= -Wtrigraphs
 CFLAGS+= -Wuninitialized
 CFLAGS+= -Wunused

Reply via email to