On Wed, Aug 22, 2018 at 08:35:23PM +0200, Reyk Floeter wrote: > Hi, > > vmctl doesn't allow to boot VMs with only a CDROM. I see no reason > for it and vmd already allows CDROM-only. > > OK?
No objection, ok mlarkin. -ml > > Via https://twitter.com/wizardishungry/status/1032327323125727232 > "Jon Williams @wizardishungry > @reykfloeter Could you consider allowing booting ISO-only vms in 6.4? > This is helpful for running container hosts (e.g. boot2docker)." > > Reyk > > Index: usr.sbin/vmctl/vmctl.c > =================================================================== > RCS file: /cvs/src/usr.sbin/vmctl/vmctl.c,v > retrieving revision 1.54 > diff -u -p -u -p -r1.54 vmctl.c > --- usr.sbin/vmctl/vmctl.c 12 Jul 2018 12:04:49 -0000 1.54 > +++ usr.sbin/vmctl/vmctl.c 22 Aug 2018 18:29:44 -0000 > @@ -98,8 +98,8 @@ vm_start(uint32_t start_id, const char * > errx(1, "too many disks"); > else if (ndisks == 0) > warnx("starting without disks"); > - if (kernel == NULL && ndisks == 0) > - errx(1, "no kernel or disk specified"); > + if (kernel == NULL && ndisks == 0 && !iso) > + errx(1, "no kernel or disk/cdrom specified"); > if (nnics == -1) > nnics = 0; > if (nnics > VMM_MAX_NICS_PER_VM) >
