On Thu, Aug 30, 2018 at 11:19:08PM -0700, Ori Bernstein wrote: > On Wed, 15 Aug 2018 23:02:16 -0700, Ori Bernstein <[email protected]> wrote: > > > Updated style from feedback from off-list. Also added checks and > > erroring for incompatible extensions. > > One more update. This revision adds explicit definitions of the > disk format, and adds regress tests for parsing it. The syntax > for it is: > > disk "foo" format "qcow2" > disk "bar" format "raw" > > If the format is left unspecified, you get a raw image. This > change is fully backwards compatible, so your configs don't > need to change. > > Alternatively, you can specify the disk format on the command > line: > > vmctl start ... -d raw:mydisk -d qcow2:moredisk \ > -d harddiskraw.img > > Again, the default format is raw, and qcow2 needs to be specified > explicitly. > > Updated patch below:
Hi Ori, I had one question about mkcluster() in src/usr.sbin/vmd/vioqcow2.c... + if (src_phys > 0 && copy_cluster(disk, base, disk->end, src_phys) == -1) + return -1; The other error cases around it do "goto fail" which calls pthread_rwlock_unlock(). Should this do the same? - Michael
