Hello,

smtp_client_state() and smtp_client_response() both do

        switch (proto->state) ...

but smtp_client_state() doesn't print the id of the bad state
in the default case. This patch makes the fatalx() message the
same for both. Does this look OK?

- Michael


Index: smtp_client.c
===================================================================
RCS file: /cvs/src/usr.sbin/smtpd/smtp_client.c,v
retrieving revision 1.6
diff -u -p -u -r1.6 smtp_client.c
--- smtp_client.c       30 Aug 2018 11:58:01 -0000      1.6
+++ smtp_client.c       1 Sep 2018 10:32:43 -0000
@@ -420,7 +420,7 @@ smtp_client_state(struct smtp_client *pr
                break;
 
        default:
-               fatalx("smtp_client_state: unknown state");
+               fatalx("%s: bad state %d", __func__, proto->state);
        }
 #undef smtp_client_state
 }

Reply via email to