Hi, Committed the diff for command. Thanks.
As for the man page, it makes sense for me. ok yasuoka On Wed, 05 Sep 2018 10:33:37 +0200 Solene Rapenne <[email protected]> wrote: > Solene Rapenne <[email protected]> wrote: >> Naoki Fukaumi <[email protected]> wrote: >> > hi tech@, >> > >> > new cpu state, CP_SPIN, was added, >> > https://marc.info/?l=openbsd-cvs&m=152630109526317&w=2 >> > >> > but there is no column for it in the header of iostat, >> > >> > $ iostat >> > tty sd0 cpu >> > tin tout KB/t t/s MB/s us ni sy in id >> > 0 1 11.47 3 0.04 0 0 0 0 0100 >> > >> > this patch adds "sp" for CP_SPIN. >> > >> > -- >> > FUKAUMI Naoki >> > >> > Index: usr.sbin/iostat/iostat.c >> > =================================================================== >> > RCS file: /cvs/src/usr.sbin/iostat/iostat.c,v >> > retrieving revision 1.40 >> > diff -u -p -u -p -r1.40 iostat.c >> > --- usr.sbin/iostat/iostat.c 10 Feb 2018 19:49:50 -0000 1.40 >> > +++ usr.sbin/iostat/iostat.c 4 Sep 2018 04:19:14 -0000 >> > @@ -229,7 +229,7 @@ header(void) >> > printf(" %16.16s ", cur.dk_name[i]); >> > >> > if (ISSET(todo, SHOW_CPU)) >> > - printf(" cpu"); >> > + printf(" cpu"); >> > printf("\n"); >> > >> > /* Sub-Headers. */ >> > @@ -254,7 +254,7 @@ header(void) >> > printf(" KB xfr time "); >> > >> > if (ISSET(todo, SHOW_CPU)) >> > - printf(" us ni sy in id"); >> > + printf(" us ni sy sp in id"); >> > printf("\n"); >> > } >> > >> >> diff for iostat.8 >> >> not sure for the text though >> is spinning time, time spent in locks? >> >> The text could be "CPU time waiting for locks" maybe >> >> Index: iostat.8 >> =================================================================== >> RCS file: /cvs/src/usr.sbin/iostat/iostat.8,v >> retrieving revision 1.26 >> diff -u -p -r1.26 iostat.8 >> --- iostat.8 17 Jan 2013 21:39:29 -0000 1.26 >> +++ iostat.8 5 Sep 2018 08:29:36 -0000 >> @@ -170,6 +170,8 @@ Seconds spent in disk activity >> % of CPU time in user mode running niced processes >> .It \&sy >> % of CPU time in system mode >> +.It \&sy >> +% of CPU time spent spinning >> .It \&in >> % of CPU time processing interrupts >> .It \&id > > the right diff is this one > > Index: iostat.8 > =================================================================== > RCS file: /cvs/src/usr.sbin/iostat/iostat.8,v > retrieving revision 1.26 > diff -u -p -r1.26 iostat.8 > --- iostat.8 17 Jan 2013 21:39:29 -0000 1.26 > +++ iostat.8 5 Sep 2018 08:29:36 -0000 > @@ -170,6 +170,8 @@ Seconds spent in disk activity > % of CPU time in user mode running niced processes > .It \&sy > % of CPU time in system mode > +.It \&sp > +% of CPU time spent spinning > .It \&in > % of CPU time processing interrupts > .It \&id >
