On Sat, Sep 08, 2018 at 11:07:30AM +0200, Anton Lindqvist wrote: > On Fri, Sep 07, 2018 at 09:22:33PM +0200, Theo Buehler wrote: > > On Fri, Sep 07, 2018 at 09:15:30PM +0200, Clemens Goessnitzer wrote: > > > This patch adds 2 missing NULL pointer checks to rebound.c after malloc(). > > > > The same function also contains an unchecked calloc. > > Since it's a daemon I guess it makes sense to continue execution instead > of dying. However, we should make sure to not leak memory along the > error paths. Also, log something when preloading the cache fails. > > Regress passed; ok?
You may want to consider returning -1 instead of 1 on failure for consistency with the rest of the daemon. Apart from that this looks good. ok
