On Sun, Sep 09, 2018 at 08:41:07AM +0200, Alexandr Nedvedicky wrote:
>  void
>  if_clone_attach(struct if_clone *ifc)
>  {
> -     rw_enter_write(&if_cloners_lock);
>       LIST_INSERT_HEAD(&if_cloners, ifc, ifc_list);
>       if_cloners_count++;
> -     rw_exit_write(&if_cloners_lock);
> -}

Could you put comment here, that the function is only called during
boot so no lock is needed?  I would prefer an assert to enforce
that, but I don't know any that is suited.

With comment, OK bluhm@

Reply via email to