On Mon, Sep 10, 2018 at 01:10:29PM +0200, Klemens Nanni wrote:
> +void
> +copy_sa(int af, struct pf_addr *pfa, struct sockaddr *sa)

Can we call it copy_satopfaddr() so we know what is copied to where?

> +{
> +     if (af == AF_INET6) 

Could we use sa->sa_family?  Then we do not have to pass an additional
parameter.

> +                     //copy_sa(n->af, &n->addr.v.a.addr, ifa->ifa_addr);
> +                     //copy_sa(n->af, &n->addr.v.a.mask, ifa->ifa_netmask);

And why do you have a comment here?

bluhm

Reply via email to