On Mon, 10 Sep 2018 20:00:16 -0700, Carlos Cardenas <cardena...@gmail.com>
wrote:
> Howdy.
>
> Attached patch allows vmd to fail fast on unknown disk format along with
> some minor clean up on logging.
>
> Comments? Ok?
>
> +--+
> Carlos
One nit:
refs = htobe16(refs);
if (pwrite(disk->fd, &refs, sizeof refs, l2cluster + 2*l2idx) != 2) {
- log_warn("could not write ref block");
+ log_warn("%s: could not write ref block", __func__);
}
return 0;
}
Should probably return -1 in the error case. I think I changed that in
my (WIP) cluster reuse change, but if you're touching the code it might
as well go in here.
--
Ori Bernstein
