On Tue, 25 Sep 2018 21:43:41 +0200, Klemens Nanni wrote:

> OK?

I think you should use __dead here too.  E.g.

static void __dead usage(void);

 - todd

> Index: getent.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/getent/getent.c,v
> retrieving revision 1.16
> diff -u -p -r1.16 getent.c
> --- getent.c  25 Sep 2018 06:48:48 -0000      1.16
> +++ getent.c  25 Sep 2018 19:41:04 -0000
> @@ -55,7 +55,7 @@
>  
>  #include <rpc/rpc.h>
>  
> -static int   usage(void);
> +static void  usage(void);
>  static int   ethers(int, char *[]);
>  static int   group(int, char *[]);
>  static int   hosts(int, char *[]);
> @@ -115,12 +115,11 @@ main(int argc, char *argv[])
>       return RV_USAGE;
>  }
>  
> -static int
> +static void
>  usage(void)
>  {
>       fprintf(stderr, "usage: %s database [key ...]\n", __progname);
>       exit(RV_USAGE);
> -     /* NOTREACHED */
>  }
>  
>  /*

Reply via email to