On Tue, Oct 02, 2018 at 11:13:35PM -0700, Ori Bernstein wrote: > > Updated version. Changes from the last diff: > > - Merge in syntax changes. > - Don't over-read when getting the base images. > - Fix relative paths in base images. > - Allow multiple derived images to use a single base image, and allow a user > with only read permisssions to base their images on top of it. > - Probe the base image size, use/validate it when craeting disk images. > - Fix style a bit (long lines, changing from sizeof foo to sizeof(foo). > - Move a define out of vmmvar.h > - And update the manpage with these changes. > - Improve error checking around creating/resolving base disk paths. >
morning. you should start new sentences on new lines - it forces a double spacing between sentences that all man pages have. if you run your proposed changes to man pages through "mandoc -Tlint", it will pick up on silly things like that. note there is also a double space in "Op Fl b" jmc > > diff --git usr.sbin/vmctl/vmctl.8 usr.sbin/vmctl/vmctl.8 > index f7890ac99f8..7a02452789c 100644 > --- usr.sbin/vmctl/vmctl.8 > +++ usr.sbin/vmctl/vmctl.8 > @@ -50,7 +50,7 @@ Using > .Xr cu 1 > connect to the console of the VM with the specified > .Ar id . > -.It Cm create Ar path Fl s Ar size > +.It Cm create Ar path Fl s Op Ar size Op Fl b Ar base > Creates a VM disk image file with the specified > .Ar path > and > @@ -65,7 +65,14 @@ or > in order to specify the disk format. > If left unspecified, the format defaults to > .Pa raw > -if it cannot be derived automatically. > +if it cannot be derived automatically. For qcow2, a > +.Ar base > +image may be specified. The base image is not modified. The derived image > +contains only the changes written by the VM. When creating a derived image, > +the > +.Ar size > +may be omitted, and probed from the base image. If it is provided, it must > +match the base image size. > .It Cm load Ar filename > Load additional configuration from the specified file. > .It Cm log brief
