On Wed, Oct 03, 2018 at 03:40:47PM +0100, Stuart Henderson wrote:
> On 2018/10/03 16:19, Claudio Jeker wrote:
> > I don't like how a lot of things got pushed into the global configuration
> > section in bgpd.conf.5 especially since some bits should be their own
> > sections. I see this for example for sets and for network statements.
> >
> > My proposal is to add two new sections which gives us the following
> > structure:
> > Macros
> > Global Configuration
> > Set Configuration
> > Network Announcements
> > MPLS VPN Configuration
> > Neighbors and Groups
> > Filter
> >
> > This allows also to write a bit more about sets and network statements
> > which is in my opinion a good thing. This is not perfect but IMO better
> > and a starting point for making this page even better.
>
> I think that's a lot better. OK with a few comments inline
Thanks, changes applied.
> > +.Ic roa-set
> > +holds a collection of Validated ROA Payloads (VRP).
> > +Each received prefix is checked against the
> > +.Ic roa-set
> > +and the Origin Validation State (OVS) is set.
> > +.Bd -literal -offset indent
> > +roa-set { 192.0.2.0/24 maxlen 24 source-as 64511
> > + 203.0.113.0/24 source-as 64496 }
> > +.Ed
> > +.El
>
> We should talk more about where these come from, but I think that's
> something to change later.
>
Indeed this section should be extended. I did not want to add too much to
this diff but I will look into adding more text for ROA validation.
Will commit tonight or tomorrow morning unless somebody objects.
--
:wq Claudio
