On Tue, Oct 09, 2018 at 01:02:11PM +1000, David Gwynne wrote:
> According to https://github.com/FRRouting/frr/pull/3106, Coverity thinks
> I made a copy and paste error regarding one of the augment calls in
> RBT_REMOVE. I'm inclined to agree.
> 
> The augment code is only used by uvm_map.c, and it seems to be fine with
> this change. I believe it coped because the augment handler it provides
> is very conservative and walks all parents on every augment call, so
> the code missing one wasn't a problem.
> 
> ok?

I'm ok with the diff.

(a bit more than a year ago, rob@ came up with the same diff due to
coverity reporting a potential copy-paste issue in our kernel)

Reply via email to