> > I quite dislike when software uses __func__ to tell me what internal > > function had an error. > > > > Why should a user see an error with the string virtio_qcow2_get_base, > > qc2_open, qc2_pwrite, etc? > > > > It feels unpolished. > > > > Possibly, but it is consistent with the rest of vmd (16 instances are > from vioqcow2.c) > > $ grep log.*__func__ *.c | wc -l > 162 > > But many of them are on lines that wrap. Overcounting a bit: > > $ grep __func__ *.c | wc -l > 474 > > If we want to change it, I think it's better as an independent patch that > converts all of vmd.
OK, then I change my comment to consistantly unpolished and getting less polished. Yes, I understand it is a powerful approach during debugging. But vmd should be getting past that stage. Especially at this layer. Each of these conditions are well understood. Dialogue a clear error message and return upwards.