This seems to substantially reduce the search space, so who is it
actually helping?

> These patterns try to detect a1a1a1 style passwords. By making the regex a bit
> more flexible we can just use one. Also now catches mMmMmM fwiw.
> 
> 
> Index: pwd_check.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/passwd/pwd_check.c,v
> retrieving revision 1.16
> diff -u -p -r1.16 pwd_check.c
> --- pwd_check.c       21 Aug 2017 21:41:13 -0000      1.16
> +++ pwd_check.c       10 Dec 2018 02:09:51 -0000
> @@ -72,15 +72,10 @@ struct pattern patterns[] = {
>               "Please use a more complicated password."
>       },
>       {
> -             "^([a-z][0-9]){1,4}$",
> +             "^([a-z0-9][a-z0-9]){1,4}$",
>               REG_EXTENDED|REG_NOSUB|REG_ICASE,
>               "Please use a more complicated password."
>       },
> -     {
> -             "^([0-9][a-z]){1,4}$",
> -             REG_EXTENDED|REG_NOSUB|REG_ICASE,
> -             "Please use a more complicated password."
> -     }
>  };
>  
>  int
> 

Reply via email to