On Sun, Dec 23, 2018 at 10:28:30AM +0100, Denis Fondras wrote:
> On Sat, Dec 22, 2018 at 11:42:36PM +0100, Klemens Nanni wrote:
> > I have no clue about MPLS, so this feedback is code-wise only:
> >
> > Did you consider using more AF agnostic code for parsing the IP address?
> >
>
> You are right, it is simpler. Thank you for the clue :)
>
> Updated diff :
>
> Index: ifconfig.8
> ===================================================================
> RCS file: /cvs/src/sbin/ifconfig/ifconfig.8,v
> retrieving revision 1.324
> diff -u -p -r1.324 ifconfig.8
> --- ifconfig.8 16 Nov 2018 12:25:29 -0000 1.324
> +++ ifconfig.8 23 Dec 2018 09:25:36 -0000
> @@ -1344,7 +1344,7 @@ is another 20-bit number which will be u
> Sets the destination address where this mpw should output.
> The
> .Ar dest-address
> -is an IPv4 address that will be used to find the nexthop in the MPLS
> +is an IPv4 or IPv6 address that will be used to find the nexthop in the MPLS
> network.
> .El
> .Sh PAIR
morning.
unless you're trying somehow to emphasise that both types of address are
supported, you could simplify the text to just:
The
.Ar dest-address
is used to find ...
jmc
