In pfctl_optimize.c r1.39 I removed the `af' parameter from `unmask()'
but accidently zapped the macro's closing paranthese.

Since DEBUG() is needlessly under an OPT_DEBUG guard here, this was not
effecting normal builds.

Add the missing ')' and remove the ifdef.

Relevant defines includede here for your convenience:

        /* #define OPT_DEBUG›   1 */
        #ifdef OPT_DEBUG
        # define DEBUG(str, v...) \
                printf("%s: " str "\n", __FUNCTION__ , ## v)
        #else
        # define DEBUG(str, v...) ((void)0)
        #endif

OK?

Index: sbin/pfctl/pfctl_optimize.c
===================================================================
RCS file: /cvs/src/sbin/pfctl/pfctl_optimize.c,v
retrieving revision 1.39
diff -u -p -r1.39 pfctl_optimize.c
--- sbin/pfctl/pfctl_optimize.c 6 Sep 2018 15:07:33 -0000       1.39
+++ sbin/pfctl/pfctl_optimize.c 3 Jan 2019 19:07:46 -0000
@@ -1232,11 +1232,9 @@ add_opt_table(struct pfctl *pf, struct p
        node_host.ifname = ifname;
        node_host.weight = addr->weight;
 
-#ifdef OPT_DEBUG
        DEBUG("<%s> adding %s/%d", (*tbl)->pt_name, inet_ntop(af,
            &node_host.addr.v.a.addr, buf, sizeof(buf)),
-           unmask(&node_host.addr.v.a.mask);
-#endif /* OPT_DEBUG */
+           unmask(&node_host.addr.v.a.mask));
 
        if (append_addr_host((*tbl)->pt_buf, &node_host, 0, 0)) {
                warn("failed to add host");

Reply via email to